Re: [PR] Replace usage of deprecated java.net.URL constructor with URI [lucene]

2023-11-03 Thread via GitHub
ChrisHegarty merged PR #12755: URL: https://github.com/apache/lucene/pull/12755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Replace usage of deprecated java.net.URL constructor with URI [lucene]

2023-11-03 Thread via GitHub
ChrisHegarty commented on PR #12755: URL: https://github.com/apache/lucene/pull/12755#issuecomment-1793024558 > oh yeah, this is also the same class that does DNS lookups in its `equals()` method :) Yeah, it’s a 20+ yr old issue, that is too late to change. I tried… Anyway, thanks f

Re: [PR] Replace usage of deprecated java.net.URL constructor with URI [lucene]

2023-11-03 Thread via GitHub
uschindler commented on PR #12755: URL: https://github.com/apache/lucene/pull/12755#issuecomment-1792961270 > > The German explanation: one is a location the other is just an opaque name. Every URL is an URI, but not otherwise round. > > If every URL is a URI, then how come `URL.equal

Re: [PR] Replace usage of deprecated java.net.URL constructor with URI [lucene]

2023-11-03 Thread via GitHub
rmuir commented on PR #12755: URL: https://github.com/apache/lucene/pull/12755#issuecomment-1792956804 > The German explanation: one is a location the other is just an opaque name. Every URL is an URI, but not otherwise round. If every URL is a URI, then how come `URL.equals()` do a D

Re: [PR] Replace usage of deprecated java.net.URL constructor with URI [lucene]

2023-11-03 Thread via GitHub
rmuir commented on PR #12755: URL: https://github.com/apache/lucene/pull/12755#issuecomment-1792862514 oh yeah, this is also the same class that does DNS lookups in its `equals()` method :) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Replace usage of deprecated java.net.URL constructor with URI [lucene]

2023-11-03 Thread via GitHub
rmuir commented on PR #12755: URL: https://github.com/apache/lucene/pull/12755#issuecomment-1792858675 needs @uschindler to review. Only germans understand the difference between URI and URL. Probably not great usability-wise for java to deprecate URL and force everyone to deal with this st