Re: [PR] Remove broken .toArray from Long/CharObjectHashMap entirely [lucene]

2024-10-10 Thread via GitHub
dweiss commented on PR #13884: URL: https://github.com/apache/lucene/pull/13884#issuecomment-2406582594 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Remove broken .toArray from Long/CharObjectHashMap entirely [lucene]

2024-10-10 Thread via GitHub
dweiss merged PR #13884: URL: https://github.com/apache/lucene/pull/13884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Remove broken .toArray from Long/CharObjectHashMap entirely [lucene]

2024-10-10 Thread via GitHub
bugmakerr commented on PR #13884: URL: https://github.com/apache/lucene/pull/13884#issuecomment-2406512304 @dweiss Thanks. I've fixed the lint error, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Remove broken .toArray from Long/CharObjectHashMap entirely [lucene]

2024-10-10 Thread via GitHub
dweiss commented on PR #13884: URL: https://github.com/apache/lucene/pull/13884#issuecomment-2405653923 Sure, thank you. The linter has failed - seems like an unused method. Please correct and perhaps add a CHANGES.txt entry with an attribution to you? -- This is an automated message from

Re: [PR] Remove broken .toArray from Long/CharObjectHashMap entirely [lucene]

2024-10-10 Thread via GitHub
bugmakerr commented on PR #13884: URL: https://github.com/apache/lucene/pull/13884#issuecomment-2405554212 @dweiss would you mind taking a look at this if you get a chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an