jpountz commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-2689114469
> I have a bias for the latter, as I was planning on improving the docs of
the oal.search package as a follow-up to provide guidance wrt how to do hybrid
search by linking to this RRF he
jpountz merged PR #13470:
URL: https://github.com/apache/lucene/pull/13470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
javanna commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1973180965
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,89 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1972397524
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,89 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1972392963
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,89 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
javanna commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1967234360
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,89 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
jpountz commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-2677780646
Thanks for taking a look. I have a bias for the latter, as I was planning on
improving the docs of the oal.search package as a follow-up to provide guidance
wrt how to do hybrid search b
javanna commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-263959
This looks good to me. Perhaps we could mark the new static method
experimental, especially if we think we are going to want to support more ways
of combining topdocs soon enough. I don'
jpountz commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-2674572334
I plan on merging this PR soon if there are no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jpountz commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-2659645405
@harenlin I took some freedom to apply my feedback and push it to your
branch. Would you like to take a look and check if it makes sense?
--
This is an automated message from the Apach
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1642654043
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
harenlin commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632394832
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632393474
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
harenlin commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632391085
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits
harenlin commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632391085
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632381076
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632257926
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632257416
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632256442
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
jpountz commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-2156511314
I'm not worried about this. If we feel like we should expose it differently
in the future, we'll do it, deprecate this function, and remove it in Lucene 11.
--
This is an automated mes
alessandrobenedetti commented on PR #13470:
URL: https://github.com/apache/lucene/pull/13470#issuecomment-2156437678
I'm not sure 'rrf' should be a direct method in topDocs:
Reciprocal Rank Fusion is just one way of combining result sets, if in the
future we want to add other algorithms h
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632111769
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632104552
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632104552
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632101267
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632101139
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1631987192
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
27 matches
Mail list logo
