Re: [PR] Performance improvements to use RWLock to access LRUQueryCache [lucene]

2024-05-10 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1584480939 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -628,7 +632,7 @@ private class LeafCache implements Accountable { LeafCache(Object

Re: [PR] Performance improvements to use RWLock to access LRUQueryCache [lucene]

2024-05-10 Thread via GitHub
benwtrent merged PR #13306: URL: https://github.com/apache/lucene/pull/13306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Performance improvements to use RWLock to access LRUQueryCache [lucene]

2024-05-10 Thread via GitHub
boicehuang commented on PR #13306: URL: https://github.com/apache/lucene/pull/13306#issuecomment-2104395723 > I think this is ready for merging. I can do the merging, but won't back port to 9x until we see nightlies. They might catch something we missed. > > @boicehuang could you add

Re: [PR] Performance improvements to use RWLock to access LRUQueryCache [lucene]

2024-05-09 Thread via GitHub
boicehuang commented on PR #13306: URL: https://github.com/apache/lucene/pull/13306#issuecomment-2103777811 > I think this is ready for merging. I can do the merging, but won't back port to 9x until we see nightlies. They might catch something we missed. > > @boicehuang could you add

Re: [PR] Performance improvements to use RWLock to access LRUQueryCache [lucene]

2024-05-08 Thread via GitHub
boicehuang commented on PR #13306: URL: https://github.com/apache/lucene/pull/13306#issuecomment-2099953047 Current improvement number of the submitted code version. doc count | field cardinality | query point | baseline QPS | candidate QPS | diff percentage | diff -- | -- | -- | -