Re: [PR] Optimize binary search call [lucene]

2024-12-30 Thread via GitHub
github-actions[bot] commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2566031064 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Optimize binary search call [lucene]

2024-12-15 Thread via GitHub
dungba88 commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2543558374 @jpountz I have changed the code to exponential search, and move the functionality to ArrayUtil. We still need two different method for `int[]` and generic array, as Java doesn't seem t

Re: [PR] Optimize binary search call [lucene]

2024-08-16 Thread via GitHub
github-actions[bot] commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2294481483 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Optimize binary search call [lucene]

2024-08-01 Thread via GitHub
dungba88 commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2264454968 @jpountz I was reading `IntArrayDocIdSetIterator`, it is a private class only exposed through `IntArrayDocIdSet`. I think we need to extend the capability here (storing the score, havin

Re: [PR] Optimize binary search call [lucene]

2024-08-01 Thread via GitHub
gsmiller commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2263350507 Ah yeah, OK thanks @jpountz. Makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Optimize binary search call [lucene]

2024-08-01 Thread via GitHub
jpountz commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2263244861 If `DocIdSetIterator#advance` gets called on large increments, then there are only so many calls that can be done because the doc ID space is quickly exhausted. However, if you only adva

Re: [PR] Optimize binary search call [lucene]

2024-08-01 Thread via GitHub
gsmiller commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2263219440 I _think_ exponential search will only outperform binary search in this case if we expect the next target to be relatively close to the "min" we're constantly "pushing up" (thanks to yo

Re: [PR] Optimize binary search call [lucene]

2024-08-01 Thread via GitHub
dungba88 commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2262677876 The `advance` will keep reducing the array size and we will generally advance small steps ahead right? Then I think exponential search makes sense. I'll try to use `IntArrayDocIdSetIter

Re: [PR] Optimize binary search call [lucene]

2024-07-31 Thread via GitHub
jpountz commented on PR #13595: URL: https://github.com/apache/lucene/pull/13595#issuecomment-2260043321 This makes sense to me. Maybe we should go one step further and perform an exponential search instead, e.g. by reusing `IntArrayDocIdSetIterator`. -- This is an automated message from