github-actions[bot] commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2676466824
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
mikemccand commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1946542491
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMap.java:
##
@@ -218,12 +231,26 @@ public void add(CharsRef input, CharsRef output, boo
mikemccand commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2642948906
Hi @msfroh -- thank you for the ping! Sorry for the slow reply ... I'll try
to review again soon, and we might be able to test impact in our Amazon product
search `SynonymGraphFilter
github-actions[bot] commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2614148431
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2582003125
@mikemccand -- do you think this needs more work? Can you work with your
team to see if this change would help reduce your heap usage?
While we allow custom synonym files on AWS Ope
github-actions[bot] commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2294482584
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
msfroh commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1701032411
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMapDirectory.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
msfroh commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1701025192
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMapDirectory.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
msfroh commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1701014637
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMapDirectory.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
msfroh commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1700987077
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMapDirectory.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
msfroh commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1700999887
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMap.java:
##
@@ -291,11 +306,35 @@ public SynonymMap build() throws IOException {
msfroh commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1700987077
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMapDirectory.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
mikemccand commented on code in PR #13054:
URL: https://github.com/apache/lucene/pull/13054#discussion_r1687872625
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/SynonymMapDirectory.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundat
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2243997751
Note: The above PR has been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2213024535
I published a PR here: https://github.com/apache/lucene/pull/13549. Please
take a look when you have time!
--
This is an automated message from the Apache Git Service.
To respond to t
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2212975749
@msfroh I also forgot about this. Let me create a PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
github-actions[bot] commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2156239861
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2130737374
@dungba88 - I forgot about this change for a while. Did you create a
separate PR for the saveMetadata change? Should I?
--
This is an automated message from the Apache Git Service.
To r
github-actions[bot] commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1992798063
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1967141003
> I realized I also need the saveMetadata change for
https://github.com/apache/lucene/pull/12985. Do you think we should make it a
standalone PR and merge first? Otherwise I've cherry-pic
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1966724748
I realized I also need the `saveMetadata` change for
https://github.com/apache/lucene/pull/12985. Do you think we should make it a
standalone PR and merge first? Otherwise I've cherry-p
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1963312776
> I could put a PR for the saveMetadata change if you prefer.
I'll update to take care of that. Thanks for the pointers!
--
This is an automated message from the Apache Git Servic
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1963208003
I could put a PR for the saveMetadata change if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1963122608
You are right, the saveMetadata is still in FST.
Now to create the FST written off heap, you need to create the corresponding
DataInput and use the FST constructor.
However
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1963078077
> @msfroh
>
> As you only need to write the FST metadata, there is no need to create the
FST. You can just call
>
> ```
> directory.writeMetadata(words.size(), maxHorizont
dungba88 commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1962302474
@msfroh
As you only need to write the FST metadata, there is no need to create the
FST. You can just call
```
directory.writeMetadata(words.size(), maxHorizontalContex
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1961803620
@dungba88 -- I'm trying to resolve conflicts with your changes, but I'm a
little stuck. I don't understand how we're supposed to use the FST APIs to
write the FST to disk now.
Aft
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1935491971
I decided to try experimenting with moving the output words back onto the
heap, since I didn't the fact that every word lookup was triggering a seek.
Running now, I got way less va
msfroh commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-1920420714
I did some rough benchmarks using the large synonym file attached to
https://issues.apache.org/jira/browse/LUCENE-3233
The benchmark code and input is at
https://github.com/msfroh/
29 matches
Mail list logo
