Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
iverase commented on PR #13460: URL: https://github.com/apache/lucene/pull/13460#issuecomment-2154127830 This class seems to have change quite a bit and some methods did not have a clear path forward for backportso I set the milestone for this change to 10.0.0 -- This is an automated mess

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
iverase merged PR #13460: URL: https://github.com/apache/lucene/pull/13460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
jpountz commented on code in PR #13460: URL: https://github.com/apache/lucene/pull/13460#discussion_r1629497818 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -664,14 +643,13 @@ synchronized void verifyOrCreateDvOnlyField( * {@code dvType} retur

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
jpountz commented on code in PR #13460: URL: https://github.com/apache/lucene/pull/13460#discussion_r1629485819 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -403,11 +385,8 @@ static final class FieldNumbers { FieldNumbers(String softDeletesFieldNam

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
jpountz commented on code in PR #13460: URL: https://github.com/apache/lucene/pull/13460#discussion_r1629484661 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -403,11 +385,8 @@ static final class FieldNumbers { FieldNumbers(String softDeletesFieldNam

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
iverase commented on code in PR #13460: URL: https://github.com/apache/lucene/pull/13460#discussion_r1629399538 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -664,14 +643,13 @@ synchronized void verifyOrCreateDvOnlyField( * {@code dvType} retur

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
iverase commented on code in PR #13460: URL: https://github.com/apache/lucene/pull/13460#discussion_r1629388801 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -403,11 +385,8 @@ static final class FieldNumbers { FieldNumbers(String softDeletesFieldNam

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
jpountz commented on code in PR #13460: URL: https://github.com/apache/lucene/pull/13460#discussion_r1629348007 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -403,11 +385,8 @@ static final class FieldNumbers { FieldNumbers(String softDeletesFieldNam

Re: [PR] Merge related HashMaps in FieldInfos#FieldNumbers into one map [lucene]

2024-06-06 Thread via GitHub
iverase commented on code in PR #13460: URL: https://github.com/apache/lucene/pull/13460#discussion_r1629301169 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -403,11 +385,8 @@ static final class FieldNumbers { FieldNumbers(String softDeletesFieldNam