github-actions[bot] commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2076082854
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
stefanvodita commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2047250772
Thank you for persisting @iamsanjay! I spend a bit of time on this and
noticed two bugs, which should be fixed by #13287. Feel free to add the changes
to your PR. I can still get so
iamsanjay commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2046550816
> @iamsanjay - thank you for working on this! I merged #12966, which should
mean the original test failure is fixed. Do you want to verify that all is
working as expected now?
I
stefanvodita commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2039599158
@iamsanjay - thank you for working on this! I merged #12966, which should
mean the original test failure is fixed. Do you want to verify that all is
working as expected now?
--
T
iamsanjay commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2020515624
@dweiss Thanks for the clarification, It does change the seed and hence was
not able to reproduce the failure case. To increase the likelihood I switch to
choosing only from two values
dweiss commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2017652016
Whenever you touch the random number generator, it'll change anything down
from there. Reiterate/Beast your tests to find a new offending seed (or improve
the probability your change fixe
stefanvodita commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2017533598
Aren't we changing the random number generation when we add the merge
policy, so we're no longer producing a failing case by chance?
--
This is an automated message from the Apach
iamsanjay commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2015519505
@benwtrent I added above code and for some reason the Facet results have
completely changed and did not include the children with value zero. Hence,
it's passing. However, If i try wit
benwtrent commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2015144997
FYI, the test is fixed by doing the following instead:
```
---
a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetValueSource.java
+++
b/lucene/face
stefanvodita commented on PR #13198:
URL: https://github.com/apache/lucene/pull/13198#issuecomment-2014855713
Thanks for working on this. Once #12966 is merged, solving #12585, we would
want to revert this change, right?
--
This is an automated message from the Apache Git Service.
To resp
10 matches
Mail list logo
