Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

2025-02-24 Thread via GitHub
dweiss commented on PR #14228: URL: https://github.com/apache/lucene/pull/14228#issuecomment-2679643415 Thanks, @msfroh ! I think it should be possible to cherry pick a series of commits from main - perhaps with minor adjustments. When you try to cherry pick this commit from main, you'll se

Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

2025-02-24 Thread via GitHub
msfroh commented on PR #14228: URL: https://github.com/apache/lucene/pull/14228#issuecomment-2679564727 > I think a backport to 10x would be nice but perhaps it's worth another issue since it's not trivial. I can take care of that. After going down the rabbit hole once with t

Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

2025-02-24 Thread via GitHub
dweiss commented on PR #14228: URL: https://github.com/apache/lucene/pull/14228#issuecomment-2678269055 I've merged this. There are conflicts when backporting to branch_10x and they sort of depend on previous fixes to spotless, so I leave this patch on main only. I think a backport to 10x w

Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

2025-02-24 Thread via GitHub
dweiss merged PR #14228: URL: https://github.com/apache/lucene/pull/14228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

2025-02-19 Thread via GitHub
rmuir commented on PR #14228: URL: https://github.com/apache/lucene/pull/14228#issuecomment-2670465446 @msfroh if you get a chance, I think you just need to merge in `main` and it will take care of that CI issue. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

2025-02-13 Thread via GitHub
dweiss commented on PR #14228: URL: https://github.com/apache/lucene/pull/14228#issuecomment-2657770674 I'll create a separate issue for hunspell tests and take care of that tomorrow, no worries. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

2025-02-13 Thread via GitHub
rmuir commented on PR #14228: URL: https://github.com/apache/lucene/pull/14228#issuecomment-2656373080 The hunspell test failure is likely an upstream issue with libreoffice dictionaries. It happened recently to me with mongolian dictionaries. Problems: * the test doesn't execute e