Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-22 Thread via GitHub
dweiss merged PR #14824: URL: https://github.com/apache/lucene/pull/14824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2994008065 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-21 Thread via GitHub
rmuir commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993725482 The runners in use might not be beefy enough for larger sizing (gc threads, thread pools, etc) to help? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-21 Thread via GitHub
github-actions[bot] commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993705268 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-21 Thread via GitHub
dweiss commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993704851 On gh runners changing these options seems to have no effect. * before removing ```-XX:TieredStopAtLevel=1 -XX:ActiveProcessorCount=1```: ![image](https://github.com/user-attachment

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-21 Thread via GitHub
github-actions[bot] commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993699244 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-21 Thread via GitHub
dweiss commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993698382 With: ``` -Xmx1g -XX:ReservedCodeCacheSize=256m -XX:TieredStopAtLevel=1 ``` I get: ``` max-workers: 8 real 0m9.768s real 0m9.486s real 0m9.501s max-workers: 1

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-21 Thread via GitHub
rmuir commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993683230 @dweiss maybe remove the parallelgc along with if you are testing. It's only needed because with 1 CPU ergonomics will default you to SerialGC which is too slow. -- This is an automated

Re: [PR] Custom google java format tasks to replace spotless [lucene]

2025-06-21 Thread via GitHub
github-actions[bot] commented on PR #14824: URL: https://github.com/apache/lucene/pull/14824#issuecomment-2993562529 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop