Re: [PR] Converted FieldEntry to record [lucene]

2024-04-15 Thread via GitHub
uschindler commented on PR #13296: URL: https://github.com/apache/lucene/pull/13296#issuecomment-2056532260 > The change looks good to me, I'd like @uschindler to have a look since he knows more about records than I do. They are not too complicated, you just have to think simpler and

Re: [PR] Converted FieldEntry to record [lucene]

2024-04-15 Thread via GitHub
uschindler commented on code in PR #13296: URL: https://github.com/apache/lucene/pull/13296#discussion_r1565551378 ## lucene/MIGRATE.md: ## @@ -180,6 +180,8 @@ access the members using method calls instead of field accesses. Affected classe - `IOContext`, `MergeInfo`, and `F

Re: [PR] Converted FieldEntry to record [lucene]

2024-04-12 Thread via GitHub
jpountz commented on code in PR #13296: URL: https://github.com/apache/lucene/pull/13296#discussion_r1562691650 ## lucene/MIGRATE.md: ## @@ -180,6 +180,8 @@ access the members using method calls instead of field accesses. Affected classe - `IOContext`, `MergeInfo`, and `Flus