Re: [PR] Backport error-prone changes from main to branch_10x [lucene]

2025-02-24 Thread via GitHub
asfgit merged PR #14286: URL: https://github.com/apache/lucene/pull/14286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Backport error-prone changes from main to branch_10x [lucene]

2025-02-24 Thread via GitHub
rmuir commented on PR #14286: URL: https://github.com/apache/lucene/pull/14286#issuecomment-2680113100 Thank you @msfroh ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Backport error-prone changes from main to branch_10x [lucene]

2025-02-24 Thread via GitHub
rmuir commented on PR #14286: URL: https://github.com/apache/lucene/pull/14286#issuecomment-2679880554 This crazy SleepingLockWrapper still lives in main/, but its `DEFAULT_POLL_INTERVAL` is `static final` there. I wonder if this got fixed in another commit or something. -- This is an au

Re: [PR] Backport error-prone changes from main to branch_10x [lucene]

2025-02-24 Thread via GitHub
msfroh commented on PR #14286: URL: https://github.com/apache/lucene/pull/14286#issuecomment-2679883061 > This crazy SleepingLockWrapper still lives in main/, but its `DEFAULT_POLL_INTERVAL` is `static final` there. I wonder if this got fixed in another commit or something. Yeah, I f

Re: [PR] Backport error-prone changes from main to branch_10x [lucene]

2025-02-24 Thread via GitHub
msfroh commented on PR #14286: URL: https://github.com/apache/lucene/pull/14286#issuecomment-2679879073 > Looks like CI fails in a check on core/. there might be more, if it gets past core/: > Oh... dang, I forgot to run locally with error-prone enabled. I'll do that and clean up

Re: [PR] Backport error-prone changes from main to branch_10x [lucene]

2025-02-24 Thread via GitHub
rmuir commented on PR #14286: URL: https://github.com/apache/lucene/pull/14286#issuecomment-2679876336 Looks like CI fails in a check on core/. there might be more, if it gets past core/: ``` /home/runner/work/lucene/lucene/lucene/core/src/java/org/apache/lucene/store/SleepingLock