Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-07 Thread via GitHub
jpountz commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2031188700 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.java: ## @@ -17,46 +17,113 @@ package org.apache.lucene.sandbox.search; +import

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-06 Thread via GitHub
jainankitk commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2030073871 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.java: ## @@ -17,46 +17,113 @@ package org.apache.lucene.sandbox.search; +imp

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-04 Thread via GitHub
jainankitk commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2029297568 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.java: ## @@ -17,46 +17,113 @@ package org.apache.lucene.sandbox.search; +imp

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-04 Thread via GitHub
jpountz commented on code in PR #14413: URL: https://github.com/apache/lucene/pull/14413#discussion_r2028458611 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/QueryProfilerBreakdown.java: ## @@ -17,46 +17,113 @@ package org.apache.lucene.sandbox.search; +import

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-02 Thread via GitHub
jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2774610745 @jpountz - The code changes are ready for review. For now, I have made changes to accommodate all the timers in `QueryProfilerTimingType`. While this does not modify (`rewrite()

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-02 Thread via GitHub
jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2774601593 > I'd have a top-level tree for everything related to initializing the search and combining results (rewrite(), createWeight(), CollectorManager#reduce) and then a list of trees for e

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-01 Thread via GitHub
jpountz commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2769456423 I'd have a top-level tree for everything related to initializing the search and combining results (rewrite(), createWeight(), CollectorManager#reduce) and then a list of trees for each s

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-03-31 Thread via GitHub
jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2767417910 @jpountz - Can you provide your thoughts on above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo