benwtrent merged PR #14084:
URL: https://github.com/apache/lucene/pull/14084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1907254811
##
lucene/core/src/java/org/apache/lucene/search/SeededKnnByteVectorQuery.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
seanmacavaney commented on PR #14084:
URL: https://github.com/apache/lucene/pull/14084#issuecomment-2577760107
Looks great, thanks @benwtrent! I'm keen to benchmark it a bit, but no need
to hold up merging it over that.
--
This is an automated message from the Apache Git Service.
To respo
benwtrent commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1907184892
##
lucene/core/src/java/org/apache/lucene/search/SeededKnnByteVectorQuery.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1906914231
##
lucene/core/src/java/org/apache/lucene/search/SeededKnnByteVectorQuery.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
benwtrent commented on PR #14084:
URL: https://github.com/apache/lucene/pull/14084#issuecomment-2576131880
@seanmacavaney @cpoerschke I am gonna merge this in the next couple of days.
I flagged the queries and such as experimental if we want to change the
interface. But I think it reached a
benwtrent commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1904255306
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -67,7 +70,21 @@ public static void search(
HnswGraphSearcher graphSearcher =
benwtrent commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1904254316
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -67,7 +70,21 @@ public static void search(
HnswGraphSearcher graphSearcher =
benwtrent commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1904253643
##
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901999056
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -67,7 +70,21 @@ public static void search(
HnswGraphSearcher graphSearcher =
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901995165
##
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901994452
##
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901988833
##
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901987699
##
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901986941
##
lucene/core/src/java/org/apache/lucene/search/knn/SeededKnnCollectorManager.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901973563
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -67,7 +70,21 @@ public static void search(
HnswGraphSearcher graphSearcher =
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901978619
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -52,7 +54,8 @@ public HnswGraphSearcher(NeighborQueue candidates, BitSet
visited)
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901977429
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -67,7 +70,21 @@ public static void search(
HnswGraphSearcher graphSearcher =
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901958473
##
lucene/core/src/java/org/apache/lucene/search/SeededKnnByteVectorQuery.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901949757
##
lucene/core/src/java/org/apache/lucene/search/KnnCollector.java:
##
@@ -85,4 +85,58 @@ public interface KnnCollector {
* @return The collected top documents
cpoerschke commented on code in PR #14084:
URL: https://github.com/apache/lucene/pull/14084#discussion_r1901949757
##
lucene/core/src/java/org/apache/lucene/search/KnnCollector.java:
##
@@ -85,4 +85,58 @@ public interface KnnCollector {
* @return The collected top documents
21 matches
Mail list logo
