iverase commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1747072284
>@iverase, I think you have to move the changes entry to Lucene 10.
I did it already in ba74da1
>I changed the Policeman Jenkins MMAP job back to Lucene Main branch. The
nex
uschindler commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1747053947
@iverase, I think you have to move the changes entry to Lucene 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
uschindler commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1747042486
P.S.: See
[docs](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/ByteBuffer.html#get(int,byte%5B%5D,int,int))
here. The method came with Java 13.
--
This is a
uschindler commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1747037797
Hi @iverase,
oh yeah. The absolute ByteBuffer gets are not available in older Java
versions.
If you want to backport, you could create a temporary ByteBuffer slice, but
if y
iverase commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1747031597
@uschindler I merged the change.
I tried to backported but it is not possible ByteBuffer#get(int, byte[],
int, int) is not available in the java version on line 9.x. I think it is
iverase merged PR #12600:
URL: https://github.com/apache/lucene/pull/12600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
iverase commented on code in PR #12600:
URL: https://github.com/apache/lucene/pull/12600#discussion_r1345506266
##
lucene/core/src/java19/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -168,6 +168,28 @@ private void readBytesBoundary(byte[] b, int offset, int
len)
iverase commented on code in PR #12600:
URL: https://github.com/apache/lucene/pull/12600#discussion_r1345506266
##
lucene/core/src/java19/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -168,6 +168,28 @@ private void readBytesBoundary(byte[] b, int offset, int
len)
uschindler commented on code in PR #12600:
URL: https://github.com/apache/lucene/pull/12600#discussion_r1345489213
##
lucene/core/src/java19/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -168,6 +168,28 @@ private void readBytesBoundary(byte[] b, int offset, int
le
iverase commented on code in PR #12600:
URL: https://github.com/apache/lucene/pull/12600#discussion_r1345475483
##
lucene/core/src/java19/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -168,6 +168,28 @@ private void readBytesBoundary(byte[] b, int offset, int
len)
iverase commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1745118236
I am just trying to have an abstraction that can replace the BytesRef output
for binary doc values with something that does not impose the internal
representation of the bytes like Bytes
uschindler commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1744981658
In general to me it is still questionable if we really need a bulk random
access byte[] reader. I am partly agree with thiy, but if somebody asks for
float[] or long[] bulk reads with
uschindler commented on PR #12600:
URL: https://github.com/apache/lucene/pull/12600#issuecomment-1744979771
I changed the https://jenkins.thetaphi.de/job/Lucene-MMAPv2-Linux/ (Linux
MMAP Job to use your branch). Please wait a bit until the checker is happy, as
it tries all differet java ver
uschindler commented on code in PR #12600:
URL: https://github.com/apache/lucene/pull/12600#discussion_r1344093638
##
lucene/core/src/java19/org/apache/lucene/store/MemorySegmentIndexInput.java:
##
@@ -168,6 +168,28 @@ private void readBytesBoundary(byte[] b, int offset, int
le
14 matches
Mail list logo
