Re: [PR] Add per-field knn vector format info in SegmentInfo [lucene]

2024-05-14 Thread via GitHub
tteofili closed pull request #13367: Add per-field knn vector format info in SegmentInfo URL: https://github.com/apache/lucene/pull/13367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add per-field knn vector format info in SegmentInfo [lucene]

2024-05-14 Thread via GitHub
tteofili commented on PR #13367: URL: https://github.com/apache/lucene/pull/13367#issuecomment-2110564180 you're right @jpountz , we can probably get away with `fieldInfo.getAttribute(PerFieldKnnVectorFormat.PER_FIELD_FORMAT_KEY)`, I didn't notice that, thanks! -- This is an automated me

Re: [PR] Add per-field knn vector format info in SegmentInfo [lucene]

2024-05-14 Thread via GitHub
jpountz commented on PR #13367: URL: https://github.com/apache/lucene/pull/13367#issuecomment-2110416918 I'm a bit confused: what is the benefit of having it on segment infos in addition to field infos? -- This is an automated message from the Apache Git Service. To respond to the message