Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-13 Thread via GitHub
rmuir closed issue #14224: TestOperations.testGetRandomAcceptedString failing URL: https://github.com/apache/lucene/issues/14224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-12 Thread via GitHub
rmuir commented on issue #14224: URL: https://github.com/apache/lucene/issues/14224#issuecomment-2655012824 This one was simpler, it is just a case where you should be getting a parsing error: https://github.com/apache/lucene/pull/14227 -- This is an automated message from the Apache Git

Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-12 Thread via GitHub
rmuir commented on issue #14224: URL: https://github.com/apache/lucene/issues/14224#issuecomment-2654406157 i think a test against old parser should show it. maybe it indirectly did the `peek()`s and `match()`s differently in the case of no content within a `[]`, and didnt try to parse it

Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-12 Thread via GitHub
rmuir commented on issue #14224: URL: https://github.com/apache/lucene/issues/14224#issuecomment-2654396301 I see `[]` in the regexp which matches no possible characters, so it creates Automata.makeEmpty(). Concatenation of empty with anything else returns empty, so that's why the test fail

Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-12 Thread via GitHub
benwtrent commented on issue #14224: URL: https://github.com/apache/lucene/issues/14224#issuecomment-2654393417 Thanks @rmuir ! I really don't know if it's a test data failure or something interesting actually broke. -- This is an automated message from the Apache Git Service. To r

Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-12 Thread via GitHub
rmuir commented on issue #14224: URL: https://github.com/apache/lucene/issues/14224#issuecomment-2654392511 I can reproduce it, thanks! My concern is around the `[]`, this is an empty "character class", maybe unlucky result from the RNG? Otherwise when 'empty' logic is wrong, usually you kn

Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-12 Thread via GitHub
rmuir commented on issue #14224: URL: https://github.com/apache/lucene/issues/14224#issuecomment-2654370971 @benwtrent I can look tonight -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] TestOperations.testGetRandomAcceptedString failing [lucene]

2025-02-12 Thread via GitHub
benwtrent commented on issue #14224: URL: https://github.com/apache/lucene/issues/14224#issuecomment-2654345727 Here is the regex string that creates the empty operations: ``` regex str: (\?){1,}\½(\]){1,}\(\]){1,}((\Ř)*){1,}[]"ᖴﴁ". ``` -- This is an automated message from t