Re: [I] Opening of vector files with ReadAdvice.RANDOM_PRELOAD [lucene]

2025-03-26 Thread via GitHub
viliam-durina commented on issue #14348: URL: https://github.com/apache/lucene/issues/14348#issuecomment-2755668181 I've ran into issue with this setting now. If the file doesn't actually fit into memory, this read advice hurts the performance significantly. With it, `madvise` is called wit

Re: [I] Opening of vector files with ReadAdvice.RANDOM_PRELOAD [lucene]

2025-03-24 Thread via GitHub
msokolov commented on issue #14348: URL: https://github.com/apache/lucene/issues/14348#issuecomment-2749231567 A question I have is how unused fields (at Search time) are handled. I guess their files may have been opened, and thus preloaded? But this could be bad. We often have people creat

Re: [I] Opening of vector files with ReadAdvice.RANDOM_PRELOAD [lucene]

2025-03-17 Thread via GitHub
jpountz commented on issue #14348: URL: https://github.com/apache/lucene/issues/14348#issuecomment-2730966937 For what it's worth, it's possible to override the read advice of vectors with something like that: ```java Path path = ...; Directory dir = new FilterDirectory(FSDirect

Re: [I] Opening of vector files with ReadAdvice.RANDOM_PRELOAD [lucene]

2025-03-17 Thread via GitHub
jainankitk commented on issue #14348: URL: https://github.com/apache/lucene/issues/14348#issuecomment-2730902349 > Lucene currently uses ReadAdvice.RANDOM when opening these files. I think it would be better to use RANDOM_PRELOAD. As per the documentation for RANDOM_PRELOAD: _

Re: [I] Opening of vector files with ReadAdvice.RANDOM_PRELOAD [lucene]

2025-03-16 Thread via GitHub
navneet1v commented on issue #14348: URL: https://github.com/apache/lucene/issues/14348#issuecomment-2727641512 @viliam-durina if you have benchmarks that shows the performance is better it will be good to raise the PR. Once PR is there maintainers can also do more tests to see if it is rea

Re: [I] Opening of vector files with ReadAdvice.RANDOM_PRELOAD [lucene]

2025-03-12 Thread via GitHub
viliam-durina commented on issue #14348: URL: https://github.com/apache/lucene/issues/14348#issuecomment-2718850463 I have the necessary change ready in my fork of Lucene, and it works for us. I wanted input from maintainers whether they think this is a good idea in general for Lucene. --

Re: [I] Opening of vector files with ReadAdvice.RANDOM_PRELOAD [lucene]

2025-03-12 Thread via GitHub
DivyanshIITB commented on issue #14348: URL: https://github.com/apache/lucene/issues/14348#issuecomment-2717999626 Hi @viliam-durina, I find this issue interesting and would like to work on it. I see that Lucene currently uses ReadAdvice.RANDOM when opening vector files (.vec and .ve