Re: [I] CompiledAutomaton not equal when NFARunAutomaton is non-null [lucene]

2024-09-04 Thread via GitHub
rmuir commented on issue #13715: URL: https://github.com/apache/lucene/issues/13715#issuecomment-2330179575 That's usually how it works, it is good stuff. To be practical, for now, I'd recommend just fixing Intervals.regex to `determinize()` so that it matches all other queries which are us

Re: [I] CompiledAutomaton not equal when NFARunAutomaton is non-null [lucene]

2024-09-04 Thread via GitHub
rmuir commented on issue #13715: URL: https://github.com/apache/lucene/issues/13715#issuecomment-2329956146 There are other related problems to fix here separately, just start with CompiledAutomaton: * `hashCode()` is inconsistent with `equals()`: either they both consider `nfaRunAutoma

Re: [I] CompiledAutomaton not equal when NFARunAutomaton is non-null [lucene]

2024-09-04 Thread via GitHub
rmuir commented on issue #13715: URL: https://github.com/apache/lucene/issues/13715#issuecomment-2329919715 @ChrisHegarty I think it might be an oversight IntervalQuery is getting an NFA, was that really intended? The following other methods on intervals are powered by automatons and

Re: [I] CompiledAutomaton not equal when NFARunAutomaton is non-null [lucene]

2024-09-04 Thread via GitHub
zhaih commented on issue #13715: URL: https://github.com/apache/lucene/issues/13715#issuecomment-2329914096 I think it's a nice to have one. Altho for the specific IntervalQuery I feel like maybe we can directly claim they're equal if the pattern is the same and not checking the automaton a

Re: [I] CompiledAutomaton not equal when NFARunAutomaton is non-null [lucene]

2024-09-04 Thread via GitHub
ChrisHegarty commented on issue #13715: URL: https://github.com/apache/lucene/issues/13715#issuecomment-2329846860 Before considering possible fixes, do we agree that there is a problem worth fixing? I’m particular thinking of the equality of IntervalQuery. -- This is an automated message