[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220531#comment-17220531 ] Atri Sharma commented on SOLR-14354: Is this no longer a blocker? > HttpShardHandler

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220311#comment-17220311 ] ASF subversion and git services commented on SOLR-14354: Commit a

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220312#comment-17220312 ] ASF subversion and git services commented on SOLR-14354: Commit a

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220313#comment-17220313 ] Cao Manh Dat commented on SOLR-14354: - Done on reverting, thank you [~dsmiley] > Htt

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220307#comment-17220307 ] ASF subversion and git services commented on SOLR-14354: Commit 1

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220308#comment-17220308 ] ASF subversion and git services commented on SOLR-14354: Commit 1

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219994#comment-17219994 ] Mark Robert Miller commented on SOLR-14354: --- It’s likely a decent improvement,

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219975#comment-17219975 ] Varun Thacker commented on SOLR-14354: -- Whenever we've taken flamegraphs (  [https:/

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219649#comment-17219649 ] David Smiley commented on SOLR-14354: - FYI I did last night and +1'ed it. BUILD SUCCE

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219012#comment-17219012 ] Cao Manh Dat commented on SOLR-14354: - [~dsmiley] can you review the PR that I just p

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219010#comment-17219010 ] ASF subversion and git services commented on SOLR-14354: Commit 1

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219008#comment-17219008 ] ASF subversion and git services commented on SOLR-14354: Commit 0

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218982#comment-17218982 ] David Smiley commented on SOLR-14354: - I started to revert but there are some difficu

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217033#comment-17217033 ] Mark Robert Miller commented on SOLR-14354: --- My main concern would go away with

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216748#comment-17216748 ] Ishan Chattopadhyaya commented on SOLR-14354: - Oh, and I withdraw my veto.

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216744#comment-17216744 ] Ishan Chattopadhyaya commented on SOLR-14354: - I think a major non optional c

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216739#comment-17216739 ] David Smiley commented on SOLR-14354: - -1, mainly because the API that is committed i

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216711#comment-17216711 ] Cao Manh Dat commented on SOLR-14354: - Let's do a vote here, shall we? I'm +1 with k

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216677#comment-17216677 ] David Smiley commented on SOLR-14354: - What's blocking is that it needs to be reverte

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216596#comment-17216596 ] Atri Sharma commented on SOLR-14354: Where are we with this issue? This is marked as

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204236#comment-17204236 ] Mark Robert Miller commented on SOLR-14354: --- I don’t think master does much con

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202700#comment-17202700 ] Amrit Sarkar commented on SOLR-14354: - Hi [~caomanhdat], absolutely. Allow me to catc

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201437#comment-17201437 ] Cao Manh Dat commented on SOLR-14354: - [~ichattopadhyaya] sorry but I gave solr-bench

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201179#comment-17201179 ] Cao Manh Dat commented on SOLR-14354: - Thank Mark for your nice words.  [~ichattopad

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201067#comment-17201067 ] Ishan Chattopadhyaya commented on SOLR-14354: - This doesn't have associated p

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199558#comment-17199558 ] David Smiley commented on SOLR-14354: - It's nice to see you participating in other is

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198892#comment-17198892 ] Mark Robert Miller commented on SOLR-14354: --- Okay, I'm not really going to be a

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198648#comment-17198648 ] ASF subversion and git services commented on SOLR-14354: Commit 5

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198574#comment-17198574 ] Mark Robert Miller commented on SOLR-14354: --- Good stuff Dat! Great list of issu

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179297#comment-17179297 ] Noble Paul commented on SOLR-14354: --- Let's keep this open till the perf runs are comple

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175118#comment-17175118 ] Cao Manh Dat commented on SOLR-14354: - [~rishisankar] sure, if you can also do the be

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175025#comment-17175025 ] Rishi Sankar commented on SOLR-14354: - [~caomanhdat] I am interested in this work as

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174236#comment-17174236 ] Cao Manh Dat commented on SOLR-14354: - Ok then I will try my best to run it. > HttpS

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174234#comment-17174234 ] Ishan Chattopadhyaya commented on SOLR-14354: - bq. Ishan Chattopadhyaya, fair

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174224#comment-17174224 ] Cao Manh Dat commented on SOLR-14354: - [~ichattopadhyaya], fair enough, do you want t

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174221#comment-17174221 ] Ishan Chattopadhyaya commented on SOLR-14354: - For a change like this, I woul

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174184#comment-17174184 ] Cao Manh Dat commented on SOLR-14354: - Hi [~dsmiley], I will try my best to spend som

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171757#comment-17171757 ] David Smiley commented on SOLR-14354: - It seems there is reasonable consensus on my p

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169136#comment-17169136 ] David Smiley commented on SOLR-14354: - My (long) message with proposal: https://list

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169049#comment-17169049 ] David Smiley commented on SOLR-14354: - I think public API changes (includes additions

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155870#comment-17155870 ] ASF subversion and git services commented on SOLR-14354: Commit 2

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155836#comment-17155836 ] Cao Manh Dat commented on SOLR-14354: - Thank you [~erickerickson], I gonna push a fix

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155825#comment-17155825 ] Erick Erickson commented on SOLR-14354: --- [~caomanhdat] This is failing 8x compilati

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155084#comment-17155084 ] ASF subversion and git services commented on SOLR-14354: Commit 5

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152629#comment-17152629 ] Noble Paul commented on SOLR-14354: --- {quote}HttpShardHandler still send requests in asy

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152611#comment-17152611 ] Cao Manh Dat commented on SOLR-14354: - Hi [~noble.paul] your comment is true but here

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152540#comment-17152540 ] Noble Paul commented on SOLR-14354: --- A lot of requests made by HttpShardHandler are syn

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152435#comment-17152435 ] Cao Manh Dat commented on SOLR-14354: - The commit end up with solution 1 and letting

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152430#comment-17152430 ] ASF subversion and git services commented on SOLR-14354: Commit a

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151939#comment-17151939 ] ASF subversion and git services commented on SOLR-14354: Commit 6

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148374#comment-17148374 ] ASF subversion and git services commented on SOLR-14354: Commit 1

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146187#comment-17146187 ] ASF subversion and git services commented on SOLR-14354: Commit 0

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146178#comment-17146178 ] ASF subversion and git services commented on SOLR-14354: Commit 8