cpoerschke commented on code in PR #12674:
URL: https://github.com/apache/lucene/pull/12674#discussion_r1407985494
##
lucene/licenses/opennlp-tools-NOTICE.txt:
##
@@ -1,11 +1,101 @@
Apache OpenNLP
Review Comment:
https://github.com/apache/opennlp/blob/opennlp-2.3.2/NOTICE
cpoerschke commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1934017872
> FYI 2.3.1 was just released.
2.3.2 just released -- https://opennlp.apache.org/news/release-232.html --
I'll update this PR
--
This is an automated message from the Apache
github-actions[bot] commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1907129893
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
epugh commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1883984387
I don't know about the migration side specifically, but based on
https://opennlp.apache.org/news/release-200.html and some of the other release
notes, here is a first stab.
```
cpoerschke commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1883534556
> What's probably missing is ... a note on migration?
Yes, indeed. It being a 1.x to 2.x dependency upgrade, I'm not yet familiar
enough with OpenNLP to gauge what's involved in
cpoerschke commented on code in PR #12674:
URL: https://github.com/apache/lucene/pull/12674#discussion_r1446425261
##
lucene/analysis/opennlp/src/tools/test-model-data/README.txt:
##
@@ -3,4 +3,4 @@ Training data derived from Reuters corpus in very unscientific
way.
Tagging do
cpoerschke commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1883525174
> It would be good migrate the model regeneration to gradle - probably a
good follow-up issue on its own though.
Makes sense, opened #13002 for that.
--
This is an automa
dweiss commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1881823621
Hi @cpoerschke - apologies for the delay. This looks ok to me. It is a pity
the dependency sucks in so much other software (slf4j included). I guess this
is unavoidable if somebody wants
github-actions[bot] commented on PR #12674:
URL: https://github.com/apache/lucene/pull/12674#issuecomment-1880900643
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
cpoerschke commented on code in PR #12674:
URL: https://github.com/apache/lucene/pull/12674#discussion_r1408000809
##
lucene/licenses/slf4j-api-LICENSE-MIT.txt:
##
@@ -0,0 +1,24 @@
+Copyright (c) 2004-2022 QOS.ch Sarl (Switzerland)
Review Comment:
https://github.com/qos-ch/s
cpoerschke commented on code in PR #12674:
URL: https://github.com/apache/lucene/pull/12674#discussion_r1407992397
##
lucene/analysis/opennlp/src/test/org/apache/lucene/analysis/opennlp/TestOpenNLPChunkerFilterFactory.java:
##
@@ -58,7 +58,7 @@ public class TestOpenNLPChunkerFil
cpoerschke commented on code in PR #12674:
URL: https://github.com/apache/lucene/pull/12674#discussion_r1407985494
##
lucene/licenses/opennlp-tools-NOTICE.txt:
##
@@ -1,11 +1,101 @@
Apache OpenNLP
Review Comment:
https://github.com/apache/opennlp/blob/opennlp-2.3.1/NOTICE
12 matches
Mail list logo
