Re: [PR] skip keyword in German Normalization Filter [lucene]

2025-03-27 Thread via GitHub
xzhang9292 closed pull request #14416: skip keyword in German Normalization Filter URL: https://github.com/apache/lucene/pull/14416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] skip keyword in German Normalization Filter [lucene]

2025-03-27 Thread via GitHub
rmuir commented on PR #14416: URL: https://github.com/apache/lucene/pull/14416#issuecomment-2757816185 i think it will introduce a ton more complexity: that's why we've pushed back on doing this for anything that isn't a stemmer. otherwise people will want LowerCaseFilter to respect it too.

Re: [PR] skip keyword in German Normalization Filter [lucene]

2025-03-27 Thread via GitHub
xzhang9292 commented on PR #14416: URL: https://github.com/apache/lucene/pull/14416#issuecomment-2756971573 > This keyword is legacy, for stemmers not normalizers. Just use ProtectedTermFilter which works with any tokenfilter without requiring modification to its code? @rmuir Thank y

Re: [PR] skip keyword in German Normalization Filter [lucene]

2025-03-26 Thread via GitHub
rmuir commented on PR #14416: URL: https://github.com/apache/lucene/pull/14416#issuecomment-2756917145 This keyword is legacy, for stemmers not normalizers. Just use ProtectedTermFilter which works with any tokenfilter without requiring modification to its code? -- This is an automated m

[PR] skip keyword in German Normalization Filter [lucene]

2025-03-26 Thread via GitHub
xzhang9292 opened a new pull request, #14416: URL: https://github.com/apache/lucene/pull/14416 Current GermanNormalizationFilter tries to normalize special German characters like ä to a, ü to u. For some words it makes sense to do so, äpfel - > apfel is like apples -> apple. But for some wo