gsmiller commented on PR #13969:
URL: https://github.com/apache/lucene/pull/13969#issuecomment-2452189489
Added an assertion and tweaked parameter naming as discussed here over in
#13972.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gsmiller commented on PR #13969:
URL: https://github.com/apache/lucene/pull/13969#issuecomment-2450411129
> I'm also considering renaming length to to since length usually is a
number of entries after from while it's an absolute end offset here
+1. I noticed this as well when writing
jpountz commented on PR #13969:
URL: https://github.com/apache/lucene/pull/13969#issuecomment-2450030846
I wrote the javadocs this way on purpose, so that it would still work to
create an IntVector/LongVector that starts before `from` and count the number
of values that are less than the ta
jpountz commented on PR #13969:
URL: https://github.com/apache/lucene/pull/13969#issuecomment-2450344763
This sounds good to me, maybe extract it to a function to avoid increasing
the method size too much? Now that you made me look harder at this code, I'm
also considering renaming `length`
gsmiller commented on PR #13969:
URL: https://github.com/apache/lucene/pull/13969#issuecomment-2450301205
@jpountz after thinking a little more, I wonder if an `assert` would make
sense to guard against unsorted data between index `0` and `from`? Probably
quite unlikely, but would also be n
gsmiller closed pull request #13969: minor javadoc correction on
VectorUtilSupport#findNextGEQ
URL: https://github.com/apache/lucene/pull/13969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
gsmiller commented on PR #13969:
URL: https://github.com/apache/lucene/pull/13969#issuecomment-2450206811
@jpountz thanks for the clarification! Let's not make the javadoc change
then since it sounds like a reasonable reason to keep the requirement that
values are sorted beginning at index
gsmiller commented on PR #13969:
URL: https://github.com/apache/lucene/pull/13969#issuecomment-244971
@jpountz was looking through #13958 retroactively to understand the change
and I _think_ I spotted a small javadoc error. Can you take a peek? Even though
this is super trivial, I wante
gsmiller opened a new pull request, #13969:
URL: https://github.com/apache/lucene/pull/13969
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
