Re: [PR] enable error-prone's DisableUnicodeInCode check [lucene]

2023-12-14 Thread via GitHub
mikemccand commented on PR #12936: URL: https://github.com/apache/lucene/pull/12936#issuecomment-1855649826 Thanks @rmuir! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] enable error-prone's DisableUnicodeInCode check [lucene]

2023-12-13 Thread via GitHub
rmuir merged PR #12936: URL: https://github.com/apache/lucene/pull/12936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[PR] enable error-prone's DisableUnicodeInCode check [lucene]

2023-12-12 Thread via GitHub
rmuir opened a new pull request, #12936: URL: https://github.com/apache/lucene/pull/12936 Previously this error-prone check was not enabled, requiring code to be simple ascii, because of violations in spatial3d. I used find-replace on the greek letters there and the tests pass. Close