Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-04-02 Thread via GitHub
jainankitk commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2021747427 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int do

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-04-01 Thread via GitHub
jainankitk commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2021750116 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java: ## @@ -98,12 +98,17 @@ public void decompress(DataInput in, int ori

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-31 Thread via GitHub
jainankitk commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2021748068 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java: ## @@ -144,10 +148,85 @@ public void decompress(DataInput in, int o

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-31 Thread via GitHub
jainankitk commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2021750116 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java: ## @@ -98,12 +98,17 @@ public void decompress(DataInput in, int ori

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-29 Thread via GitHub
kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2019766795 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int docID

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-28 Thread via GitHub
kkewwei commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2019696179 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java: ## @@ -144,10 +148,85 @@ public void decompress(DataInput in, int orig

Re: [PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-28 Thread via GitHub
jainankitk commented on code in PR #14397: URL: https://github.com/apache/lucene/pull/14397#discussion_r2019666086 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -512,6 +512,7 @@ private void doReset(int do

[PR] cache preset dict for LZ4WithPresetDictDecompressor [lucene]

2025-03-24 Thread via GitHub
kkewwei opened a new pull request, #14397: URL: https://github.com/apache/lucene/pull/14397 ### Description As mentioned in #14347, we use `LZ4WithPresetDictDecompressor` to decompress, we will always read preset dict for every doc in non-merge scenarios. If two consecutive documents fa