Re: [PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-04-05 Thread via GitHub
rmuir commented on code in PR #14388: URL: https://github.com/apache/lucene/pull/14388#discussion_r2008139072 ## lucene/expressions/src/generated/checksums/generateAntlr.json: ## @@ -1,7 +1,8 @@ { "lucene/expressions/src/java/org/apache/lucene/expressions/js/Javascript.g4

Re: [PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-03-28 Thread via GitHub
rmuir commented on code in PR #14388: URL: https://github.com/apache/lucene/pull/14388#discussion_r2008149095 ## lucene/expressions/src/generated/checksums/generateAntlr.json: ## @@ -1,7 +1,8 @@ { "lucene/expressions/src/java/org/apache/lucene/expressions/js/Javascript.g4

Re: [PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-03-23 Thread via GitHub
rmuir merged PR #14388: URL: https://github.com/apache/lucene/pull/14388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-03-21 Thread via GitHub
rmuir opened a new pull request, #14388: URL: https://github.com/apache/lucene/pull/14388 Dependency is outdated, the main changes to generated code avoid warnings in java21+ This one didn't magically work like ICU, I simply force-regenerated. I tried messing around with the gradle d

Re: [PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-03-21 Thread via GitHub
dweiss commented on code in PR #14388: URL: https://github.com/apache/lucene/pull/14388#discussion_r2008140343 ## lucene/expressions/src/generated/checksums/generateAntlr.json: ## @@ -1,7 +1,8 @@ { "lucene/expressions/src/java/org/apache/lucene/expressions/js/Javascript.g

Re: [PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-03-21 Thread via GitHub
dweiss commented on code in PR #14388: URL: https://github.com/apache/lucene/pull/14388#discussion_r2008129712 ## lucene/expressions/src/generated/checksums/generateAntlr.json: ## @@ -1,7 +1,13 @@ { + "../../../../../.gradle/caches/modules-2/files-2.1/com.ibm.icu/icu4j/72.1

Re: [PR] bump antlr 4.11.1 -> 4.13.2 [lucene]

2025-03-21 Thread via GitHub
dweiss commented on PR #14388: URL: https://github.com/apache/lucene/pull/14388#issuecomment-2744155828 > This one didn't magically work like ICU I've pushed a commit that should do the trick. ICU version wasn't in the inputs so the build didn't know it'd been updated. -- This is a