Re: [PR] Wrap Executor in TaskExecutor to never reject [lucene]

2025-02-03 Thread via GitHub
original-brownbear commented on PR #13622: URL: https://github.com/apache/lucene/pull/13622#issuecomment-2631740301 I agree @dsmiley , I actually did continue to work on this on the ES side lately in https://github.com/elastic/elasticsearch/pull/120024. What I did there was introduce log

Re: [PR] Wrap Executor in TaskExecutor to never reject [lucene]

2025-02-03 Thread via GitHub
dsmiley commented on PR #13622: URL: https://github.com/apache/lucene/pull/13622#issuecomment-2631616345 Looking back at this, might it have been better to instead wrap `TaskExecutor.invokeAll`'s call of `executor.execute` in a loop to catch `RejectedExecutionException` and then don't both

Re: [PR] Wrap Executor in TaskExecutor to never reject [lucene]

2024-07-31 Thread via GitHub
original-brownbear merged PR #13622: URL: https://github.com/apache/lucene/pull/13622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Wrap Executor in TaskExecutor to never reject [lucene]

2024-07-31 Thread via GitHub
original-brownbear commented on PR #13622: URL: https://github.com/apache/lucene/pull/13622#issuecomment-2261022408 npnp, thanks for taking a look Adrien! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Wrap Executor in TaskExecutor to never reject [lucene]

2024-07-31 Thread via GitHub
original-brownbear commented on PR #13622: URL: https://github.com/apache/lucene/pull/13622#issuecomment-2260327524 > if the first half of segments is submitted successfully and the second half is rejected, there are chances that the second half gets processed while the first half is still

Re: [PR] Wrap Executor in TaskExecutor to never reject [lucene]

2024-07-31 Thread via GitHub
original-brownbear commented on PR #13622: URL: https://github.com/apache/lucene/pull/13622#issuecomment-2260282144 Done @jpountz, just added 1k count-up tasks, that reliably got me rejections :) -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] Wrap Executor in TaskExecutor to never reject [lucene]

2024-07-31 Thread via GitHub
original-brownbear opened a new pull request, #13622: URL: https://github.com/apache/lucene/pull/13622 Make it so rejected tasks are execute right away on the caller thread. Users of the API shouldn't have to worry about rejections when we don't expose any upper limit to the task count that