uschindler merged PR #13048:
URL: https://github.com/apache/lucene/pull/13048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #13048:
URL: https://github.com/apache/lucene/pull/13048#issuecomment-1915682882
Looks fine. Have you added all PR numbers that were merged today and the
ones I approved already? I will merge them soon.
--
This is an automated message from the Apache Git Servic
sabi0 commented on PR #13048:
URL: https://github.com/apache/lucene/pull/13048#issuecomment-1915656350
I hope I understood your suggestions with CHANGES.txt right. Please let me
know if I should change something there.
--
This is an automated message from the Apache Git Service.
To respon
uschindler commented on PR #13048:
URL: https://github.com/apache/lucene/pull/13048#issuecomment-1915623346
It would be nice to have a changes entry in `CHANGES.txt`. You can add it to
9.10 section and I will cherry pick the changes in Lucene 9.x.
As you have more open PRs with cleanu
sabi0 commented on PR #13048:
URL: https://github.com/apache/lucene/pull/13048#issuecomment-1915392997
I've added my name to the GitHub profile. And will review the PRs to
describe the reasoning.
-Dmitry
--
This is an automated message from the Apache Git Service.
To respond to the
sabi0 commented on code in PR #13048:
URL: https://github.com/apache/lucene/pull/13048#discussion_r1470080459
##
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##
@@ -185,7 +185,7 @@ static VectorizationProvider lookup(boolean testMode)
uschindler commented on PR #13048:
URL: https://github.com/apache/lucene/pull/13048#issuecomment-1915203166
For your cleanup pull requests to be merged, please make sure to add a
description to your issue, why those changes are useful.
I agree to merge this (any some of your other PRs
uschindler commented on code in PR #13048:
URL: https://github.com/apache/lucene/pull/13048#discussion_r1469932148
##
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##
@@ -185,7 +185,7 @@ static VectorizationProvider lookup(boolean test
sabi0 opened a new pull request, #13048:
URL: https://github.com/apache/lucene/pull/13048
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
