Re: [PR] Use growNoCopy when copying bytes in BytesRefBuilder [lucene]

2024-10-20 Thread via GitHub
iverase merged PR #13930: URL: https://github.com/apache/lucene/pull/13930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[PR] Use growNoCopy when copying bytes in BytesRefBuilder [lucene]

2024-10-18 Thread via GitHub
iverase opened a new pull request, #13930: URL: https://github.com/apache/lucene/pull/13930 I noticed in BytesRefBuilder that we have growNoCopy method, still when calling the methods #copyBytes (reseting the contents on the buffer) we are calling grow. It seems more logical to use in that