Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-04-19 Thread via GitHub
uschindler merged PR #13252: URL: https://github.com/apache/lucene/pull/13252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-04-07 Thread via GitHub
vsop-479 commented on PR #13252: URL: https://github.com/apache/lucene/pull/13252#issuecomment-2041954466 @mikemccand I resolved the conflicts, and added a `CHANGES.txt` entry. Please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To

Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-04-01 Thread via GitHub
vsop-479 commented on PR #13252: URL: https://github.com/apache/lucene/pull/13252#issuecomment-2029857674 I will resolve the conflicts, and try to find other handwritten loops. Thanks @mikemccand @uschindler . -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-04-01 Thread via GitHub
mikemccand commented on PR #13252: URL: https://github.com/apache/lucene/pull/13252#issuecomment-2029844532 Woops, there are now conflicts here (from the binary search PR) -- maybe you could resolve them @vsop-479, and add a `CHANGES.txt` entry too? Thanks! -- This is an automated messag

Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-03-30 Thread via GitHub
rmuir commented on PR #13252: URL: https://github.com/apache/lucene/pull/13252#issuecomment-2028078833 This looks like a good improvement, these `Arrays` methods become much faster than the home-written loops for longer arrays. -- This is an automated message from the Apache Git Service.

Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-03-29 Thread via GitHub
vsop-479 commented on PR #13252: URL: https://github.com/apache/lucene/pull/13252#issuecomment-2027939691 @mikemccand Please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th