Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-24 Thread via GitHub
gf2121 merged PR #12710: URL: https://github.com/apache/lucene/pull/12710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
dungba88 commented on code in PR #12710: URL: https://github.com/apache/lucene/pull/12710#discussion_r1368616130 ## lucene/core/src/java/org/apache/lucene/util/fst/IntSequenceOutputs.java: ## @@ -43,28 +44,29 @@ public IntsRef common(IntsRef output1, IntsRef output2) { asse

Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
dungba88 commented on code in PR #12710: URL: https://github.com/apache/lucene/pull/12710#discussion_r1368349251 ## lucene/core/src/java/org/apache/lucene/util/fst/IntSequenceOutputs.java: ## @@ -43,28 +44,29 @@ public IntsRef common(IntsRef output1, IntsRef output2) { asse

Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
dungba88 commented on code in PR #12710: URL: https://github.com/apache/lucene/pull/12710#discussion_r1368341788 ## lucene/core/src/java/org/apache/lucene/util/fst/IntSequenceOutputs.java: ## @@ -43,28 +44,29 @@ public IntsRef common(IntsRef output1, IntsRef output2) { asse

Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
dungba88 commented on code in PR #12710: URL: https://github.com/apache/lucene/pull/12710#discussion_r1368341788 ## lucene/core/src/java/org/apache/lucene/util/fst/IntSequenceOutputs.java: ## @@ -43,28 +44,29 @@ public IntsRef common(IntsRef output1, IntsRef output2) { asse

Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
gf2121 commented on code in PR #12710: URL: https://github.com/apache/lucene/pull/12710#discussion_r1368344352 ## lucene/core/src/java/org/apache/lucene/util/fst/IntSequenceOutputs.java: ## @@ -43,28 +44,29 @@ public IntsRef common(IntsRef output1, IntsRef output2) { assert

Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
dungba88 commented on code in PR #12710: URL: https://github.com/apache/lucene/pull/12710#discussion_r1368341788 ## lucene/core/src/java/org/apache/lucene/util/fst/IntSequenceOutputs.java: ## @@ -43,28 +44,29 @@ public IntsRef common(IntsRef output1, IntsRef output2) { asse

Re: [PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
dungba88 commented on code in PR #12710: URL: https://github.com/apache/lucene/pull/12710#discussion_r1368339258 ## lucene/core/src/java/org/apache/lucene/util/fst/IntSequenceOutputs.java: ## @@ -43,28 +44,29 @@ public IntsRef common(IntsRef output1, IntsRef output2) { asse

[PR] Use Arrays#mismatch for Outputs#common operations [lucene]

2023-10-23 Thread via GitHub
gf2121 opened a new pull request, #12710: URL: https://github.com/apache/lucene/pull/12710 Make `Outputs#common` take advantage of `Arrays#mismatch`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go