Re: [PR] Update the IOContext on IndexInput rather than the ReadAdvice [lucene]

2025-05-23 Thread via GitHub
github-actions[bot] commented on PR #14702: URL: https://github.com/apache/lucene/pull/14702#issuecomment-2903924729 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Update the IOContext on IndexInput rather than the ReadAdvice [lucene]

2025-05-23 Thread via GitHub
thecoop commented on code in PR #14702: URL: https://github.com/apache/lucene/pull/14702#discussion_r2104201080 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -124,7 +124,7 @@ public abstract void search( * * The default implementation retu

Re: [PR] Update the IOContext on IndexInput rather than the ReadAdvice [lucene]

2025-05-23 Thread via GitHub
github-actions[bot] commented on PR #14702: URL: https://github.com/apache/lucene/pull/14702#issuecomment-2903798515 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Update the IOContext on IndexInput rather than the ReadAdvice [lucene]

2025-05-22 Thread via GitHub
jpountz commented on code in PR #14702: URL: https://github.com/apache/lucene/pull/14702#discussion_r2102989752 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -124,7 +124,7 @@ public abstract void search( * * The default implementation retu

Re: [PR] Update the IOContext on IndexInput rather than the ReadAdvice [lucene]

2025-05-22 Thread via GitHub
github-actions[bot] commented on PR #14702: URL: https://github.com/apache/lucene/pull/14702#issuecomment-2900966501 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Update the IOContext on IndexInput rather than the ReadAdvice [lucene]

2025-05-22 Thread via GitHub
thecoop opened a new pull request, #14702: URL: https://github.com/apache/lucene/pull/14702 Update the `IOContext` on `IndexInput` implementations rather than the `ReadAdvice`. This change means that `ReadAdvice` is now only used by `MMapDirectory` and friends. Note that this is a refactori