Re: [PR] Update QueryUtils to use CollectorManager [lucene]

2024-09-25 Thread via GitHub
github-actions[bot] commented on PR #13748: URL: https://github.com/apache/lucene/pull/13748#issuecomment-2375493347 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Update QueryUtils to use CollectorManager [lucene]

2024-09-10 Thread via GitHub
javanna commented on code in PR #13748: URL: https://github.com/apache/lucene/pull/13748#discussion_r1752834380 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/QueryUtils.java: ## @@ -345,175 +348,201 @@ public static void checkSkipTo(final Query q, final Index

Re: [PR] Update QueryUtils to use CollectorManager [lucene]

2024-09-10 Thread via GitHub
msfroh commented on code in PR #13748: URL: https://github.com/apache/lucene/pull/13748#discussion_r1752775181 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/QueryUtils.java: ## @@ -345,175 +348,201 @@ public static void checkSkipTo(final Query q, final IndexS

Re: [PR] Update QueryUtils to use CollectorManager [lucene]

2024-09-09 Thread via GitHub
msfroh commented on PR #13748: URL: https://github.com/apache/lucene/pull/13748#issuecomment-2339574918 I had another thought while walking home. Both of the anonymous CollectorManagers are the same (but produce slightly different collectors). What if you split it out into an inner class th

Re: [PR] Update QueryUtils to use CollectorManager [lucene]

2024-09-09 Thread via GitHub
msfroh commented on code in PR #13748: URL: https://github.com/apache/lucene/pull/13748#discussion_r1751112687 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/QueryUtils.java: ## @@ -345,175 +348,199 @@ public static void checkSkipTo(final Query q, final IndexS