dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155495405
Feel free to push to that PR, Uwe. I think I'm done for the day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155493207
Thanks. The other one which is special is distribution.tests project. This
one starts a blank test runner without modules and initializes module system
inside.
I think we shoul
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155485845
I filed https://github.com/apache/lucene/pull/13471 to quiet down those two
warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155466471
It appears random because there are multiple runners and messages are
proxied back to the console interleaved with everything else. I managed to
debug this by running with ``--max-workers
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155425720
> These messages are sys-outed from each forked test runner and echoed as
'system.err' by the main gradle process. You can see them in the debug log if
you run gradle with -debug:
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155396070
I also see these warnings, which you've mentioned:
```
2024-06-07T14:17:29.1508657Z WARNING: Java vector incubator module is not
readable. For optimal vector performance, pass '--add
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155392575
And looking at JDK sources, I don't think there is a way to dodge those
warnings.
```
> java --add-modules jdk.incubator.vector -version
WARNING: Using incubator modules: jdk.incu
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155387049
These messages are sys-outed from each forked test runner and echoed as
'system.err' by the main gradle process. You can see them in the debug log if
you run gradle with -debug:
```
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155292753
> What's the command/ jdk that produces these warnings for you, Uwe?
Java 21 with "Gradlew test". You see it also on Policeman Jenkins on every
Lucene main build.
I can r
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2155054873
What's the command/ jdk that produces these warnings for you, Uwe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154978721
the api vs implementation difference is about how configurations are
inherited and then exported. See [1]. I'm not sure what's happening with regard
to the warning - let me know if you'd
jpountz commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154632683
FWIW moving my `~/.gradle` directory to a filesystem that is not encrypted
worked around the problem.
--
This is an automated message from the Apache Git Service.
To respond to the mes
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154617527
Most error messages regarding the modules are also seen on Gradle 8.6, so
its not a new issue. Sorry for false alarm.
I will still investigate this. It seems to have indeed some
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154584633
I think I know the problem. It looks like Gradle test runner loads those
classes for some checks outside of tests. This is why the message appear
randomly in the output.
In
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154578383
When checking jenkisn builds, the message...
```
WARNING: Unknown module: org.apache.lucene.core specified to
--enable-native-access
```
...appears on random gradle
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154569035
This seems to be a message out of context. When running expressions tests it
has the vector incubator enabled.
The message comes from somewhere about the not readable module com
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154553906
If the "moduleApi" dependency is wanted then it makes sense to me. But then
we should only add the jvmArg if the module is linked at all. Not sure how to
test this.
So basicall
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154550898
Not sure what's the problem with both projects; in the test configuration
all looks fine. Maybe we have not seen those messages before as Gradle did not
print them. New version seems
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154532698
i still see some problems during tests regarding vector module. I have to
check what's going on. Possibly some test system properties issue. It looks
like the vector module is not alw
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154523213
Hi,
on my windows pc (which also has limitations on length of path names), I
have seen not issues. On my new laptop I havent perl installed at moment, so
building docs failed, but
jpountz commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2154447314
I'm getting errors since upgrading to Gradle 8.8 that I can't figure out how
to fix. When running with `--stacktrace`, I see the following error that seems
to be the root cause. I was no
ChrisHegarty merged PR #13453:
URL: https://github.com/apache/lucene/pull/13453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2151610526
> Yeah, I think the biggest problem is to find one task which executes
everything in the whole Gradle Build... We would need some Gradle Coverage
Report!
I don't think we can find
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2150671839
> I ran regenerate - it found another small issue with InstallationLocation,
now fixed.
Yeah, I think the biggest problem is to find one task which executes
everything in the w
ChrisHegarty commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2150435190
I ran regenerate - it found another small issue with InstallationLocation,
now fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2150296383
The problem with gradle updates is always: theres is always a small piece of
build logic not tested that breaks. Its hard to test the whole thing unless you
also run regenerate or do
uschindler commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2150292708
> @uschindler I was motivated to do this upgrade since stumbling into issues
trying to verify the 9.11 RC1 build with `--test-alternative-java
`, and kept running into silly configura
dweiss commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2149701905
You're very welcome. Upgrading gradle is risky as it may entail changes in
their APIs that only surface once a task is actually used (dynamic code) but
there's really no other way to do i
ChrisHegarty commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2149664517
Thanks for the review @dweiss. ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ChrisHegarty commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2149663385
I'm planning on backporting this to the 9.x branch, unless there are
concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ChrisHegarty commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2149287115
@uschindler I was motivated to do this upgrade since stumbling into issues
trying to verify the 9.11 RC1 build with `--test-alternative-java
`, and kept running into silly configura
ChrisHegarty commented on PR #13453:
URL: https://github.com/apache/lucene/pull/13453#issuecomment-2149264617
While not strictly necessary to be able to run tests with JDK 22, upgrading
the gradle wrapper will simplify usage. Since one can just set JAVA_HOME,
rather than both JAVA_HOME and
ChrisHegarty commented on code in PR #13453:
URL: https://github.com/apache/lucene/pull/13453#discussion_r1627277388
##
gradle/testing/alternative-jdk-support.gradle:
##
@@ -88,6 +88,6 @@ if (jvmGradle != jvmCurrent) {
// Set up root project's properties.
rootProject.ext.runti
ChrisHegarty opened a new pull request, #13453:
URL: https://github.com/apache/lucene/pull/13453
This commit updates the Gradle wrapper to 8.8, which has support for Java 22.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
34 matches
Mail list logo
