iverase commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2667648238
Thank you @Tim-Brooks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
iverase merged PR #14213:
URL: https://github.com/apache/lucene/pull/14213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
iverase commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2665599329
Thanks @Tim-Brooks, tests look good.
I will be merging this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Tim-Brooks commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2660154259
> @Tim-Brooks Could you add an entry in CHANGES.txt? It should be under the
10.2 version, thanks!
I made this change and added some more tests. Let me know if any additional
te
iverase commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2656318509
@Tim-Brooks Could you add an entry in CHANGES.txt? It should be under the
10.2 version, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
iverase commented on code in PR #14213:
URL: https://github.com/apache/lucene/pull/14213#discussion_r1952672292
##
lucene/core/src/java/org/apache/lucene/index/StoredFieldVisitor.java:
##
@@ -41,15 +40,17 @@ public abstract class StoredFieldVisitor {
protected StoredFieldVisi
iverase commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2653747350
+1 I like the idea of encapsulating the DataInput and length inside
`StoredFieldDataInput`, and yes, it gives symmetry between the read and the
write side.
--
This is an automated mes
iverase commented on code in PR #14213:
URL: https://github.com/apache/lucene/pull/14213#discussion_r1952663407
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/compressing/Lucene50CompressingStoredFieldsReader.java:
##
@@ -25,12 +25,7 @@
import org
Tim-Brooks commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2649363258
> I'm curious if we should make it an actual record?
Haha probably. I actually did not check Lucene's language level when
producing the PR.
I'll continue to refine this a
jpountz commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2649287798
> I went with this initial approach as it aligns with the fact that
StoredFieldsWriter already supports DataInput (seemingly for merges).
Indeed, the change that introduced this ca
Tim-Brooks opened a new pull request, #14213:
URL: https://github.com/apache/lucene/pull/14213
Allows a StoredField to be created from a DataInput.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Tim-Brooks commented on PR #14213:
URL: https://github.com/apache/lucene/pull/14213#issuecomment-2640892230
I am opening this proposed change to support writing a stored field from a
byte source which does not require a contiguous array allocation. The reason I
am proposing this is because
12 matches
Mail list logo
