github-actions[bot] commented on PR #13936:
URL: https://github.com/apache/lucene/pull/13936#issuecomment-2455970248
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
mikemccand commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1808871571
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -117,7 +117,8 @@ public PriorityQueue(int maxSize, Supplier
sentinelObjectSupplier) {
dweiss commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1808146179
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -270,7 +280,7 @@ public final boolean remove(T element) {
return false;
}
- private
original-brownbear commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1807955670
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -270,7 +280,7 @@ public final boolean remove(T element) {
return false;
}
dweiss commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1807927256
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -270,7 +280,7 @@ public final boolean remove(T element) {
return false;
}
- private
original-brownbear commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1807876827
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -117,26 +117,29 @@ public PriorityQueue(int maxSize, Supplier
sentinelObjectSuppli
original-brownbear commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1807876659
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -270,7 +280,7 @@ public final boolean remove(T element) {
return false;
}
original-brownbear commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1807873638
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -270,7 +280,7 @@ public final boolean remove(T element) {
return false;
}
dweiss commented on code in PR #13936:
URL: https://github.com/apache/lucene/pull/13936#discussion_r1807867567
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -270,7 +280,7 @@ public final boolean remove(T element) {
return false;
}
- private
original-brownbear commented on PR #13936:
URL: https://github.com/apache/lucene/pull/13936#issuecomment-2425018683
I think the queue methods changed here in isolation get a far bigger
improvement than 1% in many cases. Plus making methods like the ones adjusted
here smaller and easier on
rmuir commented on PR #13936:
URL: https://github.com/apache/lucene/pull/13936#issuecomment-2424867914
This results in a lot more code complexity, which makes maintenance
difficult. Maybe the version of java you are testing with has a bug in its
register allocator or something?
seri
original-brownbear opened a new pull request, #13936:
URL: https://github.com/apache/lucene/pull/13936
Saving some field accesses results in small but visible savings:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDevPct
12 matches
Mail list logo
