Re: [PR] Specialise DirectMonotonicReader when it only contains one block [lucene]

2025-03-17 Thread via GitHub
iverase closed pull request #14358: Specialise DirectMonotonicReader when it only contains one block URL: https://github.com/apache/lucene/pull/14358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Specialise DirectMonotonicReader when it only contains one block [lucene]

2025-03-16 Thread via GitHub
iverase commented on PR #14358: URL: https://github.com/apache/lucene/pull/14358#issuecomment-2728327145 I understand what you say, I will close this then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Specialise DirectMonotonicReader when it only contains one block [lucene]

2025-03-16 Thread via GitHub
jpountz commented on PR #14358: URL: https://github.com/apache/lucene/pull/14358#issuecomment-2727467298 I'm wary about adding all these micro-optimizations to reduce the per-segment per-field overhead. They hurt readability and may easily get lost over time when codecs get replaced with ne

Re: [PR] Specialise DirectMonotonicReader when it only contains one block [lucene]

2025-03-16 Thread via GitHub
iverase commented on code in PR #14358: URL: https://github.com/apache/lucene/pull/14358#discussion_r1997607493 ## lucene/core/src/java/org/apache/lucene/util/packed/DirectMonotonicReader.java: ## @@ -90,102 +140,142 @@ public static DirectMonotonicReader getInstance(Meta meta,

[PR] Specialise DirectMonotonicReader when it only contains one block [lucene]

2025-03-16 Thread via GitHub
iverase opened a new pull request, #14358: URL: https://github.com/apache/lucene/pull/14358 While looking into some heap dumps, I notice in the DirectMonotonicReader.Meta objects hold by segments that the case of single value block is actually common. I wondered if we could specialize that