LuXugang merged PR #12405:
URL: https://github.com/apache/lucene/pull/12405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
LuXugang commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1797551478
> Tests fail because the optimization kicks in in more cases than the test
expects, it's not clear to me yet if it's a bug or not.
You are correct @jpountz , the optimization kick
LuXugang commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1793958700
Sure thing @jpountz , I would work on this in the next few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
jpountz commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1792713630
Tests fail because the optimization kicks in in more cases than the test
expects, it's not clear to me yet if it's a bug or not.
--
This is an automated message from the Apache Git Ser
jpountz commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1792654011
I did my best at fixing conflicts, @LuXugang are you able to check the
changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jpountz commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1792600276
Sorry, since I had approved the PR, I had not understood it was still
waiting on me. It's a great change, let's see how to get it in.
--
This is an automated message from the Apache Gi
mikemccand commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1790852894
@LuXugang @jpountz it looks like this PR went through some great discussions
/ iterations and was close towards the end, but it has accumulated some
conflicts now?
--
This is an au