Re: [PR] Simplify PForUtil construction and cleanup its code gen a little [lucene]

2024-10-21 Thread via GitHub
original-brownbear merged PR #13932: URL: https://github.com/apache/lucene/pull/13932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Simplify PForUtil construction and cleanup its code gen a little [lucene]

2024-10-21 Thread via GitHub
original-brownbear commented on PR #13932: URL: https://github.com/apache/lucene/pull/13932#issuecomment-2426636569 That said :) thanks Adrien, merging :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Simplify PForUtil construction and cleanup its code gen a little [lucene]

2024-10-21 Thread via GitHub
original-brownbear commented on PR #13932: URL: https://github.com/apache/lucene/pull/13932#issuecomment-2426635537 W're also too confident in results I think: https://github.com/mikemccand/luceneutil/pull/308 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Simplify PForUtil construction and cleanup its code gen a little [lucene]

2024-10-21 Thread via GitHub
original-brownbear commented on PR #13932: URL: https://github.com/apache/lucene/pull/13932#issuecomment-2426308076 @jpountz 🤦‍♂️ I noticed this too but kept attributing this to CPU savings helping JIT and the like on my weaker benchmark box (feeling really clever about myself) ... but now

[PR] Simplify PForUtil construction and cleanup its code gen a little [lucene]

2024-10-19 Thread via GitHub
original-brownbear opened a new pull request, #13932: URL: https://github.com/apache/lucene/pull/13932 Generate cleaner code for PForUtil that has no dead parameters. Also: PForUtil instances always create their own `ForUtil`, so we can inline that into the field declaration. Also,