Re: [PR] Removing TermInSetQuery array ctor [lucene]

2023-11-30 Thread via GitHub
slow-J commented on PR #12837: URL: https://github.com/apache/lucene/pull/12837#issuecomment-1833404097 > +1 to this simplification. Let's also get rid of `public TermInSetQuery(RewriteMethod rewriteMethod, String field, BytesRef... terms)`? Thanks Greg, I think I could have been more

Re: [PR] Removing TermInSetQuery array ctor [lucene]

2023-11-29 Thread via GitHub
gsmiller commented on PR #12837: URL: https://github.com/apache/lucene/pull/12837#issuecomment-1832910639 +1 to this simplification. Let's also get rid of `public TermInSetQuery(RewriteMethod rewriteMethod, String field, BytesRef... terms)`? -- This is an automated message from the Apache

[PR] Removing TermInSetQuery array ctor [lucene]

2023-11-23 Thread via GitHub
slow-J opened a new pull request, #12837: URL: https://github.com/apache/lucene/pull/12837 Creating a PR for the items discussed in https://github.com/apache/lucene/issues/12243. Currently, calling the [`KeywordField#newSetQuery`](https://github.com/apache/lucene/blob/main/lu