Re: [PR] Remove some BitSet#nextSetBit code duplication [lucene]

2024-08-01 Thread via GitHub
gsmiller commented on PR #13625: URL: https://github.com/apache/lucene/pull/13625#issuecomment-2264403347 Thanks @epotyom for the feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Remove some BitSet#nextSetBit code duplication [lucene]

2024-08-01 Thread via GitHub
gsmiller merged PR #13625: URL: https://github.com/apache/lucene/pull/13625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Remove some BitSet#nextSetBit code duplication [lucene]

2024-08-01 Thread via GitHub
epotyom commented on code in PR #13625: URL: https://github.com/apache/lucene/pull/13625#discussion_r1700906253 ## lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java: ## @@ -337,34 +337,23 @@ private int firstDoc(int i4096, int i4096upper) { @Override pub

Re: [PR] Remove some BitSet#nextSetBit code duplication [lucene]

2024-08-01 Thread via GitHub
gsmiller commented on PR #13625: URL: https://github.com/apache/lucene/pull/13625#issuecomment-2264023189 @epotyom this minor refactoring occurred to me after merging your recent work. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] Remove some BitSet#nextSetBit code duplication [lucene]

2024-08-01 Thread via GitHub
gsmiller opened a new pull request, #13625: URL: https://github.com/apache/lucene/pull/13625 After merging #13559 I noticed an opportunity to remove some redundant code in the `nextSetBit` implementations. -- This is an automated message from the Apache Git Service. To respond to the mess