mikemccand commented on PR #12690:
URL: https://github.com/apache/lucene/pull/12690#issuecomment-1773775196
Thanks @dungba88 -- I'll wait to backport this until after backporting
https://github.com/apache/lucene/pull/12633
--
This is an automated message from the Apache Git Service.
To re
mikemccand merged PR #12690:
URL: https://github.com/apache/lucene/pull/12690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
mikemccand commented on PR #12690:
URL: https://github.com/apache/lucene/pull/12690#issuecomment-1773767253
Thanks @dungba88 -- looks great, I'll merge soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
dungba88 commented on PR #12690:
URL: https://github.com/apache/lucene/pull/12690#issuecomment-1773630051
As the other PR has been merged, I have rebased and resolved the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dungba88 commented on PR #12690:
URL: https://github.com/apache/lucene/pull/12690#issuecomment-1770371305
That's ok for me too! I'll rebase after the other PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mikemccand commented on PR #12690:
URL: https://github.com/apache/lucene/pull/12690#issuecomment-1770366875
Actually, I'm nervous about my git merging skills! Let's try to review/push
the [RAM limited FST building PR](https://github.com/apache/lucene/pull/12633)
first?
--
This is an aut
dungba88 opened a new pull request, #12690:
URL: https://github.com/apache/lucene/pull/12690
### Description
Follow-up of https://github.com/apache/lucene/pull/12646. NodeHash still
depends on both FSTCompiler and FST. With the current method signature, one can
create the NodeHash wi
