Re: [PR] Remove deprecated code [lucene]

2024-04-11 Thread via GitHub
jpountz merged PR #13286: URL: https://github.com/apache/lucene/pull/13286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Remove deprecated code [lucene]

2024-04-10 Thread via GitHub
jpountz commented on code in PR #13286: URL: https://github.com/apache/lucene/pull/13286#discussion_r1559754236 ## lucene/CHANGES.txt: ## @@ -98,6 +98,9 @@ API Changes * GITHUB#13241: Remove Accountable interface on KnnVectorsReader. (Pulkit Gupta) +* GITHUB#13262: Remove

Re: [PR] Remove deprecated code [lucene]

2024-04-10 Thread via GitHub
iamsanjay commented on PR #13286: URL: https://github.com/apache/lucene/pull/13286#issuecomment-2047290711 I added MIGRATE docs. Let me know if that's not required. There is one more class pending `SortField`. I am still looking into some of the test cases that are failing , we may have t

Re: [PR] Remove deprecated code [lucene]

2024-04-10 Thread via GitHub
jpountz commented on PR #13286: URL: https://github.com/apache/lucene/pull/13286#issuecomment-2046894099 @iamsanjay Yes please go ahead. All these problems should be easy to address by these various projects. Thanks for checking! -- This is an automated message from the Apache Git Service

Re: [PR] Remove deprecated code [lucene]

2024-04-10 Thread via GitHub
iamsanjay commented on PR #13286: URL: https://github.com/apache/lucene/pull/13286#issuecomment-2046812811 I looked into different Search engines whether they use it or not -- Many of them still using the deprecated code. 1. `LongPoint.newDistanceFeatureQuery` (ElasticSearch uses it htt

Re: [PR] Remove deprecated code [lucene]

2024-04-10 Thread via GitHub
jpountz commented on PR #13286: URL: https://github.com/apache/lucene/pull/13286#issuecomment-2046689556 Thanks for looking into this. I think I'd rather keep `VH_BE_DOUBLE` for now for consistency, since we're also keeping the INT, LONG and FLOAT BE variants. - In addition to IntFie