Re: [PR] Remove delayed seek optimization. [lucene]

2023-11-17 Thread via GitHub
jpountz merged PR #12815: URL: https://github.com/apache/lucene/pull/12815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Remove delayed seek optimization. [lucene]

2023-11-16 Thread via GitHub
jpountz commented on PR #12815: URL: https://github.com/apache/lucene/pull/12815#issuecomment-1814493098 Here are results on `wikibigall`, none of the p-values seem significant: ``` TaskQPS baseline StdDevQPS my_modified_version StdDev

[PR] Remove delayed seek optimization. [lucene]

2023-11-16 Thread via GitHub
jpountz opened a new pull request, #12815: URL: https://github.com/apache/lucene/pull/12815 I think that this optimization was introduced because `advanceShallow` may advance skip lists and then never decode a block of postings. But actually `IndexInput#seek` is cheap, including on `NIOFSDi