Re: [PR] Remove bits method from DocIdSet [lucene]

2025-02-26 Thread via GitHub
javanna merged PR #14290: URL: https://github.com/apache/lucene/pull/14290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Remove bits method from DocIdSet [lucene]

2025-02-25 Thread via GitHub
javanna commented on PR #14290: URL: https://github.com/apache/lucene/pull/14290#issuecomment-2683098818 Yes, the only usage is in QueryBitSetProducer, that was already previously casting anyways. I will try to apply your suggesting as a follow-up once I merged this change. Also, that one m

Re: [PR] Remove bits method from DocIdSet [lucene]

2025-02-25 Thread via GitHub
jpountz commented on PR #14290: URL: https://github.com/apache/lucene/pull/14290#issuecomment-2683084817 > leaving a single leftover usage in BitDocIdSet Is it because of `QueryBitSetProducer`? If so it looks like this class could be refactored to not use `BitDocIdSet`. All it needs i

[PR] Remove bits method from DocIdSet [lucene]

2025-02-25 Thread via GitHub
javanna opened a new pull request, #14290: URL: https://github.com/apache/lucene/pull/14290 The bits method is now redundant in the DocIdSet base class. This commit removes it, while leaving a single leftover usage in BitDocIdSet as a new method that is specific to that implementation. --