Re: [PR] Remove IOException from MultiTermQuery#getTermsCount [lucene]

2024-08-30 Thread via GitHub
gsmiller commented on PR #13701: URL: https://github.com/apache/lucene/pull/13701#issuecomment-2321956725 ++ thanks for the cleanup. I can't remember what I was thinking when I put that throws declaration in. I must have had some subclass that needed this while working on the change but I d

Re: [PR] Remove IOException from MultiTermQuery#getTermsCount [lucene]

2024-08-30 Thread via GitHub
ChrisHegarty merged PR #13701: URL: https://github.com/apache/lucene/pull/13701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

[PR] Remove IOException from MultiTermQuery#getTermsCount [lucene]

2024-08-29 Thread via GitHub
cbuescher opened a new pull request, #13701: URL: https://github.com/apache/lucene/pull/13701 Neither this method nor any of the two overrides can throw an IOException. This change removes the throws clauses from this method in order simplify not have to handle them on the callers side. -