Re: [PR] Remove FST constructors with DataInput for metadata [lucene]

2023-11-28 Thread via GitHub
mikemccand commented on PR #12803: URL: https://github.com/apache/lucene/pull/12803#issuecomment-1830145262 This one is also low risk for 9.9.0 -- it's cutting over to a cleaner FST ctor API, and has been baking in main for almost a week. I had meant to backport last week but Turkey interv

Re: [PR] Remove FST constructors with DataInput for metadata [lucene]

2023-11-22 Thread via GitHub
mikemccand commented on PR #12803: URL: https://github.com/apache/lucene/pull/12803#issuecomment-1822773144 Hmm trying to backport but `FSTTermsReader.java` had conflicts which I tried to resolve and then scary test failures and now I ran out of time for the moment! Will take it up again s

Re: [PR] Remove FST constructors with DataInput for metadata [lucene]

2023-11-22 Thread via GitHub
mikemccand merged PR #12803: URL: https://github.com/apache/lucene/pull/12803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[PR] Remove FST constructors with DataInput for metadata [lucene]

2023-11-13 Thread via GitHub
dungba88 opened a new pull request, #12803: URL: https://github.com/apache/lucene/pull/12803 ### Description Remove FST constructors with DataInput for metadata, in favor of the new constructor with FSTMetadata -- This is an automated message from the Apache Git Service. To respond