Re: [PR] Refactor and javadoc update for KNN vector writer classes [lucene]

2024-07-08 Thread via GitHub
zhaih merged PR #13548: URL: https://github.com/apache/lucene/pull/13548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] Refactor and javadoc update for KNN vector writer classes [lucene]

2024-07-08 Thread via GitHub
zhaih commented on code in PR #13548: URL: https://github.com/apache/lucene/pull/13548#discussion_r1669056420 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java: ## @@ -139,6 +142,54 @@ public int nextDoc() throws IOException { } } + /** + * Give

Re: [PR] Refactor and javadoc update for KNN vector writer classes [lucene]

2024-07-08 Thread via GitHub
zhaih commented on code in PR #13548: URL: https://github.com/apache/lucene/pull/13548#discussion_r1669054287 ## lucene/core/src/java/org/apache/lucene/index/FieldUpdatesBuffer.java: ## @@ -356,7 +356,7 @@ BufferedUpdate next() throws IOException { } } -BytesRe

Re: [PR] Refactor and javadoc update for KNN vector writer classes [lucene]

2024-07-08 Thread via GitHub
benwtrent commented on code in PR #13548: URL: https://github.com/apache/lucene/pull/13548#discussion_r1669043121 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java: ## @@ -139,6 +142,54 @@ public int nextDoc() throws IOException { } } + /** + *

[PR] Refactor and javadoc update for KNN vector writer classes [lucene]

2024-07-07 Thread via GitHub
zhaih opened a new pull request, #13548: URL: https://github.com/apache/lucene/pull/13548 ### Description * Refactor logic of translating old ord to new ord * Javadoc for Lucene99HnswVectorsFormat is a bit outdated after we separate FlatVectorsFormat out, updated -- This