Re: [PR] Refactor Lucene95 to allow off heap vector reader reuse [lucene]

2023-10-10 Thread via GitHub
benwtrent merged PR #12629: URL: https://github.com/apache/lucene/pull/12629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Refactor Lucene95 to allow off heap vector reader reuse [lucene]

2023-10-09 Thread via GitHub
benwtrent commented on PR #12629: URL: https://github.com/apache/lucene/pull/12629#issuecomment-1753485937 I am going to merge this unless there is prevailing negative sentiment. This change should significantly reduce code churn for vector codecs that require reading/writing vectors in a f

[PR] Refactor Lucene95 to allow off heap vector reader reuse [lucene]

2023-10-06 Thread via GitHub
benwtrent opened a new pull request, #12629: URL: https://github.com/apache/lucene/pull/12629 While going through: https://github.com/apache/lucene/pull/12582 I noticed that for a while now, our offheap vector readers haven't changed at all. We just keep copying them around for no rea