Re: [PR] Reduce heap usage for knn index writers [lucene]

2024-07-10 Thread via GitHub
benwtrent merged PR #13538: URL: https://github.com/apache/lucene/pull/13538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [PR] Reduce heap usage for knn index writers [lucene]

2024-07-08 Thread via GitHub
benwtrent commented on PR #13538: URL: https://github.com/apache/lucene/pull/13538#issuecomment-2215637537 Related: https://github.com/apache/lucene/pull/13553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Reduce heap usage for knn index writers [lucene]

2024-07-03 Thread via GitHub
gautamworah96 commented on PR #13538: URL: https://github.com/apache/lucene/pull/13538#issuecomment-2207757150 Thanks for the quick turnaround on this Ben. I am not too familiar with this code and am taking some time off this week. I'll try to review the code by Friday. In the meant

[PR] Reduce heap usage for knn index writers [lucene]

2024-07-03 Thread via GitHub
benwtrent opened a new pull request, #13538: URL: https://github.com/apache/lucene/pull/13538 This slightly reduces heap utilization for KnnIndex writers by: - Only constructing one `DocsWithFieldSet` instead of 3 for Scalar quantized HNSW formats - Only having one `List` instead